joshelser commented on a change in pull request #29:
URL: https://github.com/apache/hbase-filesystem/pull/29#discussion_r750826981



##########
File path: 
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
##########
@@ -161,7 +161,7 @@ protected void writeUnlock(Path p) throws IOException {
       get(p).writeLock().release();

Review comment:
       Yeah, right as usual. I want to figure out why my unit test isn't 
failing like I think it should, given this.
   
   However, I think I can interpret you see this as an improvement, but there 
is more work to be done (citing the problems, but approving this PR)? Just 
wanted to double check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to