d-c-manning commented on a change in pull request #3972:
URL: https://github.com/apache/hbase/pull/3972#discussion_r776033981
##########
File path: bin/region_mover.rb
##########
@@ -493,11 +493,29 @@ def getFilename(options, targetServer, port)
return filename
end
+def getServersRSGroup(rsgroup_admin, hostname, port)
+ rsgroup = rsgroup_admin.getRSGroupOfServer(Address.fromParts(hostname,
+ java.lang.Integer.parseInt(port)))
+ return rsgroup unless rsgroup.nil?
+ begin
+ regions = getRegions(getConfiguration(), hostname)
Review comment:
Does this work? I believe the call to `getRegions` requires a
`ServerName` object, and here we just have a string of the `hostname` (with no
`port` or `startcode`.) Compare to
https://github.com/apache/hbase/blob/1813237699a72f666217c352525c6736781fe3d9/bin/region_mover.rb#L319-L330
where we call `stripServer` to get the host's `ServerName` object from the
call to `getServers` which returns a collection of `ServerName`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
