virajjasani commented on a change in pull request #3972:
URL: https://github.com/apache/hbase/pull/3972#discussion_r776597674
##########
File path: bin/region_mover.rb
##########
@@ -493,11 +493,29 @@ def getFilename(options, targetServer, port)
return filename
end
+def getServersRSGroup(rsgroup_admin, hostname, port)
+ rsgroup = rsgroup_admin.getRSGroupOfServer(Address.fromParts(hostname,
+ java.lang.Integer.parseInt(port)))
+ return rsgroup unless rsgroup.nil?
+ begin
+ regions = getRegions(getConfiguration(), hostname)
Review comment:
As of today, we don't have any particular UT to validate region_mover
functionality on branch-1 (one of the primary reasons to move region_mover
logic to RegionMover class in branch-2), hence we need to validate it locally
by running region_mover.rb (with RSGroup enabled for this change at least).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
