Apache9 commented on pull request #4055: URL: https://github.com/apache/hbase/pull/4055#issuecomment-1020217396
> Is there a way, currently, to identify when the load was not correct? Or does it always parse the contents with no error, despite not parsing the contents correctly? > > We have the "first" SFT version ready to ship internally. Am worried how bad this is, as it would break compatibility when we then upgrade to version including this change. The possibility is low, usually it will lead to an InvalidProtocolBufferException. When testing the FSTableDescriptors, the TableDescriptor is ~300 bytes, and I've tested the to read 1 byte, 2 bytes... And finally when I reached ~50 bytes, the parse succeeded without error, but given an invalid table name. And since the content itself is very small, it is not likely to have split in the middle, and on typical OSS it is impossible to write a partial object right? The semantice is all or nothing. But distributed storage system design is to fight with 'small possibility' right? As if it happens, it will lead to data loss. So I suggest your internal version to also include this PR, or at least we should be binary compatible. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
