joshelser commented on pull request #4055: URL: https://github.com/apache/hbase/pull/4055#issuecomment-1021585492
Thanks for the ping, Duo. I'm still curious about what you saw. > I've tested the to read 1 byte, 2 bytes... And finally when I reached ~50 bytes, the parse succeeded without error You have a filelist which you noticed giving a this TableNotFoundException when it was parsed. When you tried parsing it by writing some custom code, you saw that with different lengths provided, the protobuf parser gave different errors? You are assuming that, eventually, we may have a case where HBase may write out a SFT file with a bad size (maybe HBase or HDFS bug), and this should protect us in that case? The simple crc at the head of the file sounds reasonable to prevent that causing bigger problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
