[ https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289515#comment-13289515 ]
stack commented on HBASE-6162: ------------------------------ Who is 'clarence'? Seems whack that hbase-commons needs to know about the 'REGIONINFO_DELIMITER'... but we can do finer grained cleanup later. I won't bring over TestConst. These top-level constants only interface I think an ugly anti-pattern. I'll take care of making things work w/o bringing over TestConst, no worries. Otherwise, looks good. Lets see how hadoopqa does. Good on you Matt > Move KeyValue to hbase-common module > ------------------------------------ > > Key: HBASE-6162 > URL: https://issues.apache.org/jira/browse/HBASE-6162 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.96.0 > Reporter: Matt Corgan > Assignee: Matt Corgan > Fix For: 0.96.0 > > Attachments: HBASE-6162-v1.patch > > > * pull KeyValue up to hbase-common module > This is part of the modularization strategy in HBASE-5977, and is > specifically necessary to modularize HBASE-4676. > also brings these classes to hbase-common: > * ClassSize, HeapSize > * HTestConst > * TestKeyValue, KeyValueTestUtil > * LoadTestKVGenerator, TestLoadTestKVGenerator > * MD5Hash > moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to > HConstants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira