[ https://issues.apache.org/jira/browse/HBASE-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290531#comment-13290531 ]
stack commented on HBASE-6162: ------------------------------ Ok. Lets leave comparators as they are for now. Can break them out in another jira. Locally, tests seem to do the right thing w/ patch applied: {code} ..... [INFO] --- maven-surefire-plugin:2.12-TRUNK-HBASE-2:test (default-test) @ hbase-common --- [INFO] Surefire report directory: /Users/stack/checkouts/trunk/hbase-common/target/surefire-reports [INFO] Using configured provider org.apache.maven.surefire.junitcore.JUnitCoreProvider ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.TestKeyValue Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.056 sec Running org.apache.hadoop.hbase.util.TestBytes Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.04 sec Running org.apache.hadoop.hbase.util.TestLoadTestKVGenerator Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.626 sec Results : Tests run: 30, Failures: 0, Errors: 0, Skipped: 0 ... {code} > Move KeyValue to hbase-common module > ------------------------------------ > > Key: HBASE-6162 > URL: https://issues.apache.org/jira/browse/HBASE-6162 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.96.0 > Reporter: Matt Corgan > Assignee: Matt Corgan > Fix For: 0.96.0 > > Attachments: HBASE-6162-v1.patch > > > * pull KeyValue up to hbase-common module > This is part of the modularization strategy in HBASE-5977, and is > specifically necessary to modularize HBASE-4676. > also brings these classes to hbase-common: > * ClassSize, HeapSize > * HTestConst > * TestKeyValue, KeyValueTestUtil > * LoadTestKVGenerator, TestLoadTestKVGenerator > * MD5Hash > moves a trivial constant (HRegionInfo.DELIMITER) from HRegionInfo to > HConstants -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira