anmolnar commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1071063417
> LGTM. please give another try and see if we can have a clean build. > > [nit] I may miss something but I'm wondered if we have any test or manual that has use `HBASE_NETTY_RPCSERVER_TLS_ENABLED=true` ? this is not a blocker, and I think adding the ssl header should be as straightforward as it tested in TestX509Util @taklwu Yes, I think an e2e test would make perfect sense here like we did for the JWT. We might also need a combined test for encryption + JWT. Let me work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
