anmolnar commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1075177041
> Does zookeeper client use netty and use sync when connecting to zookeeper server? When building the async client in HBase we uses the async operation for zookeeper client, if it is the case then I think we may have performance issue then... Nope. It uses a CountDownLatch to wait for the connection to be fully established before dropping packets into the pipeline. The effect is pretty much the same, but there's an important difference: ZK uses dedicated SendThread to do the transport and blocking is not a problem there. Anyways, I've managed to resolve this by using the `ChannelFuture` provided by connect(). That should be the Netty-way that we're looking for here. I'll push it soon with other code review feedback items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
