Apache9 commented on code in PR #4390:
URL: https://github.com/apache/hbase/pull/4390#discussion_r886326423
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -2042,6 +2043,22 @@ public void abort() throws IOException {
@Override
public boolean needsCompaction() {
+ // For some system compacting, we set selectNow to false, and the files do
not
Review Comment:
In general I do not fully understand what is the problem here...
The problem is we schedule too many compactions, because of how we know
whether there is a compaction running is through the filesCompacting? This is
only true for system compaction? Then why not change the logic of requesting
system compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
