bsglz commented on code in PR #4390:
URL: https://github.com/apache/hbase/pull/4390#discussion_r888213692
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##########
@@ -2042,6 +2043,22 @@ public void abort() throws IOException {
@Override
public boolean needsCompaction() {
+ // For some system compacting, we set selectNow to false, and the files do
not
Review Comment:
The current logic is an improvement introduced by HBASE-8665, which could
get better store file selection.
I think that patch is useful, just bring some side effect, and this patch
want to fix it.
BTW, skimming that patch maybe helpful to understand.
Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
