bbeaudreault commented on code in PR #4788:
URL: https://github.com/apache/hbase/pull/4788#discussion_r1096293825
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -2399,14 +2405,19 @@ private void startActiveMasterManager(int infoPort)
throws KeeperException {
Threads.sleep(timeout);
}
}
- MonitoredTask status = TaskMonitor.get().createStatus("Master startup");
- status.setDescription("Master startup");
+
+ // Here for the master startup process, we use TaskGroup to monitor the
whole progress.
+ // The UI is similar to how Hadoop designed the startup page for the
NameNode.
+ // See HBASE-21521 for more details.
+ boolean ignoreClearStartupStatus =
+ conf.getBoolean("hbase.master.ignore.clear.startup.status", true);
+ startupTaskGroup = TaskGroup.createTaskGroup(ignoreClearStartupStatus,
"Master startup");
try {
- if (activeMasterManager.blockUntilBecomingActiveMaster(timeout, status))
{
- finishActiveMasterInitialization(status);
+ if (activeMasterManager.blockUntilBecomingActiveMaster(timeout,
startupTaskGroup)) {
+ finishActiveMasterInitialization(startupTaskGroup);
}
} catch (Throwable t) {
- status.setStatus("Failed to become active: " + t.getMessage());
Review Comment:
can we no longer include the message here? seems like maybe useful context
lost, but not sure
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -2399,14 +2405,19 @@ private void startActiveMasterManager(int infoPort)
throws KeeperException {
Threads.sleep(timeout);
}
}
- MonitoredTask status = TaskMonitor.get().createStatus("Master startup");
- status.setDescription("Master startup");
+
+ // Here for the master startup process, we use TaskGroup to monitor the
whole progress.
+ // The UI is similar to how Hadoop designed the startup page for the
NameNode.
+ // See HBASE-21521 for more details.
+ boolean ignoreClearStartupStatus =
+ conf.getBoolean("hbase.master.ignore.clear.startup.status", true);
Review Comment:
im not really clear on the point of this config. looks like this boolean
gets passed into the TaskGroup's createStatus call, but we never set that
before.
would prefer not to add new configs if possible. otherwise would like to be
clearer on why one would ever want to change this value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
