bbeaudreault commented on code in PR #4788:
URL: https://github.com/apache/hbase/pull/4788#discussion_r1098117172
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -1198,6 +1199,9 @@ private void
finishActiveMasterInitialization(MonitoredTask status) throws IOExc
}
// Set master as 'initialized'.
setInitialized(true);
+ startupTaskGroup.markComplete("Initialization successful");
+ MonitoredTask status =
+ TaskMonitor.get().createStatus("Progress after master initialized",
false, true);
Review Comment:
should this be `true` now? so it shows in task monitor?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java:
##########
@@ -85,14 +85,22 @@ public static synchronized TaskMonitor get() {
}
public MonitoredTask createStatus(String description) {
- return createStatus(description, false);
+ return createStatus(description, true);
}
- public MonitoredTask createStatus(String description, boolean ignore) {
- return createStatus(description, ignore, false);
+ public MonitoredTask createStatus(String description, boolean track) {
+ return createStatus(description, track, false);
}
- public synchronized MonitoredTask createStatus(String description, boolean
ignore,
+ /**
+ * Create a monitored task for users to inquire about the status
+ * @param description description of the status
+ * @param track whether to track(e.g. show/clear/expire) the task in
the
+ * {@link TaskMonitor}
+ * @param enableJournal enable when the task contains some stage journals
+ * @return a monitored task
+ */
+ public synchronized MonitoredTask createStatus(String description, boolean
track,
Review Comment:
since you inverted this boolean, we need to update all callers to invert
whatever they passed previously. looks like there are only a handful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
