[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408530#comment-13408530 ]
Hadoop QA commented on HBASE-6336: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535332/HBASE-6336.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestClassLoading Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//console This message is automatically generated. > Split point should not be equal with start row or end row > --------------------------------------------------------- > > Key: HBASE-6336 > URL: https://issues.apache.org/jira/browse/HBASE-6336 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: chunhui shen > Assignee: chunhui shen > Fix For: 0.96.0 > > Attachments: HBASE-6336.patch > > > Should we allow split point equal with region's start row or end row? > {code} > // if the midkey is the same as the first and last keys, then we cannot > // (ever) split this region. > if (this.comparator.compareRows(mk, firstKey) == 0 && > this.comparator.compareRows(mk, lastKey) == 0) { > if (LOG.isDebugEnabled()) { > LOG.debug("cannot split because midkey is the same as first or " + > "last row"); > } > {code} > Here, I think it is a mistake. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira