[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412795#comment-13412795 ]
stack commented on HBASE-6336: ------------------------------ @Ram Thanks. So, hbase-6059 added our writing of empty store files it seems. I remember that now. So, if we throw an exception because its empty but higher up we are returning split point of null -- that the empty region is not splittable -- it doesn't seem like an issue (its just ugly). For sure we should commit Chunhui's patch on this issue. Good stuff lads. > Split point should not be equal with start row or end row > --------------------------------------------------------- > > Key: HBASE-6336 > URL: https://issues.apache.org/jira/browse/HBASE-6336 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: chunhui shen > Assignee: chunhui shen > Fix For: 0.96.0 > > Attachments: HBASE-6336.patch > > > Should we allow split point equal with region's start row or end row? > {code} > // if the midkey is the same as the first and last keys, then we cannot > // (ever) split this region. > if (this.comparator.compareRows(mk, firstKey) == 0 && > this.comparator.compareRows(mk, lastKey) == 0) { > if (LOG.isDebugEnabled()) { > LOG.debug("cannot split because midkey is the same as first or " + > "last row"); > } > {code} > Here, I think it is a mistake. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira