[ 
https://issues.apache.org/jira/browse/HBASE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409289#comment-13409289
 ] 

Harsh J commented on HBASE-5145:
--------------------------------

bq. If we expose 'hbase.master.wait.on.regionservers.mintostart', we should 
expose the other parameters as well ?

We already do expose those properties (they are read from configs).

The plan is to properly make them use constants via HBASE-3274, which I've been 
slacking on lately but plan to rebase and resume again very soon.

So for this change, which in reality was only removing the useless minServers' 
set property and using the right one (a bug), I thought I'll also constantize 
them as I go.

bq. We should change the wording.

Agree, and will do.


                
> HMasterCommandLine's -minServers seems to be useless.
> -----------------------------------------------------
>
>                 Key: HBASE-5145
>                 URL: https://issues.apache.org/jira/browse/HBASE-5145
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>    Affects Versions: 0.94.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>         Attachments: HBASE-5145.patch
>
>
> HMasterCommandLine gets a number via -minServers opt. and sets it to a config 
> param "hbase.regions.server.count.min".
> This config is not used anywhere else.
> Perhaps it wants to use "hbase.master.wait.on.regionservers.mintostart" 
> instead?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to