[ 
https://issues.apache.org/jira/browse/HBASE-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409564#comment-13409564
 ] 

stack commented on HBASE-6337:
------------------------------

@Chunhui The patch looks good.  Thanks for all the cleanup.  moveSplitLogFile 
could be named better since now there is no actually moving being done.  Call 
it finishSplitLog or something?  Have you checked out the open region side of 
the affair to see if any conditions under which we might bungle the replay of 
recovered.edits files?  I don't think it possible as long as split finishes 
successfully before region opens (or we crash out the cluster if we can't 
split).
                
> [MTTR] Remove renaming tmp log file in SplitLogManager 
> -------------------------------------------------------
>
>                 Key: HBASE-6337
>                 URL: https://issues.apache.org/jira/browse/HBASE-6337
>             Project: HBase
>          Issue Type: Bug
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: HBASE-6337v1.patch, HBASE-6337v2.patch, 
> HBASE-6337v3.patch
>
>
> As HBASE-6309 mentioned, we also encounter problem of 
> distributed-log-splitting take much more time than matser-local-log-splitting 
> because lots of SplitLogManager 's renaming operations when finishing task.
> Could we try to remove renaming tmp log file in SplitLogManager through 
> splitting log to regions' recover.edits directory directly as the same as the 
> master-local-log-splitting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to