bbeaudreault commented on code in PR #5488:
URL: https://github.com/apache/hbase/pull/5488#discussion_r1384836073
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##########
@@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {
return classLoaderLoaded;
}
+ private static final String PARSE_FROM = "parseFrom";
+
+ // We don't bother using the dynamic CLASS_LOADER above, because currently
we can't support
+ // optimizing dynamically loaded classes. We can do it once we build for
java9+, see the todo
+ // in ReflectedFunctionCache
+ private static final ReflectedFunctionCache<byte[], Filter> FILTERS =
ReflectedFunctionCache
+ .create(ProtobufUtil.class.getClassLoader(), Filter.class, byte[].class,
PARSE_FROM);
Review Comment:
Correct we'd need to expand our package search, which may lead to increased
start times.
I've had this branch hanging around for a long time, I'd like to get this
shipped and then we can tackle custom filters in a follow up when I or someone
has time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
