bbeaudreault commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1800247752
I deployed this to one of our prod servers, which is an extreme case that typically spends about 12% of time deserializing Filters. With the patch, it spends less than 5% time now. I also instrumented the initialization a bit: ``` ProtobufUtil: Took 377ms to create ClassPath ReflectedFunctionCache: Took 138ms to initialize ReflectedFunctionCache for 27 Filters ReflectedFunctionCache: Took 42ms to initialize ReflectedFunctionCache for 9 ByteArrayComparables ``` So it's about 5ms to create one of these, but the ClassPath.from() call is quite expensive and will depend on the size of the classpath (could be worse on clients that do other things). I'm going to take a look at lazy loading these on demand. Barring that, I'll at the very least re-use one ClassPath object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
