vinayakphegde commented on code in PR #5528:
URL: https://github.com/apache/hbase/pull/5528#discussion_r1398666429
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java:
##########
@@ -398,4 +414,33 @@ public void archiveMetaLog(final ServerName serverName) {
LOG.warn("Failed archiving meta log for server " + serverName, ie);
}
}
+
+ private static Stoppable createDummyStoppable() {
+ return new Stoppable() {
+ private volatile boolean isStopped = false;
+
+ @Override
+ public void stop(String why) {
+ isStopped = true;
+ }
+
+ @Override
+ public boolean isStopped() {
+ return isStopped;
+ }
+ };
+ }
+
+ public ScheduledChore getOldWALsDirSizeUpdaterChore() {
+ return new ScheduledChore("UpdateOldWALsDirSize", createDummyStoppable(),
OLD_WAL_DIR_UPDATE_INTERVAL) {
Review Comment:
If we disable it, won't we encounter issues with the incorrect results of
the oldWALs directory size JMX metrics? Could that potentially be a problem?
That's why I didn't make it configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
