wchevreuil commented on code in PR #5528:
URL: https://github.com/apache/hbase/pull/5528#discussion_r1407961823
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java:
##########
@@ -89,6 +89,12 @@ public boolean accept(Path p) {
// create the split log lock
private final Lock splitLogLock = new ReentrantLock();
+ // old WALs directory size in bytes
+ private long oldWALsDirSize;
+
+ // old WALs directory size calculation interval
+ private final int OLD_WAL_DIR_UPDATE_INTERVAL = 5 * 60 * 1000; // 5 mins
Review Comment:
Where is this used?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/OldWALsDirSizeUpdaterChore.java:
##########
Review Comment:
Nit: let's call it "OldWALsDirSizeChore"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
