kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1443676077
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:
##########
@@ -464,7 +464,6 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
lastCleanCell = null;
lastCleanCellSeqId = 0;
}
- writer.append(c);
Review Comment:
DualFIleWriter works with both append() and the new appendAll(). I added the
appendAll() for the compaction performance reasons as appendAll() eliminates
the row key comparison for the cells of the same row (except the first cell).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
