kadirozde commented on code in PR #5545:
URL: https://github.com/apache/hbase/pull/5545#discussion_r1443689986


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java:
##########
@@ -300,7 +300,7 @@ private double getMidStripeSplitRatio(long smallerSize, 
long largerSize, long la
 
   @Override
   public Collection<HStoreFile> getFilesForScan(byte[] startRow, boolean 
includeStartRow,
-    byte[] stopRow, boolean includeStopRow) {
+    byte[] stopRow, boolean includeStopRow, boolean onlyLatestVersion) {

Review Comment:
   StoreFileManager is an interface implemented by DefaultStoreFileManager and 
StripeStoreFileManager. DefaultStoreFileManager needs this new parameter but 
StripeStoreFileManager does not currently.  I changed the signature of 
StoreFileManager#getFilesForScan() to add this new parameter. I am open to 
suggestions for better handling this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to