NihalJain commented on code in PR #5625: URL: https://github.com/apache/hbase/pull/5625#discussion_r1452571357
########## hbase-it/pom.xml: ########## @@ -408,6 +408,10 @@ <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-minikdc</artifactId> </dependency> + <dependency> Review Comment: > I think the exclusion is done via [HBASE-22052](https://issues.apache.org/jira/browse/HBASE-22052)? The culprit is indeed [HBASE-22052](https://issues.apache.org/jira/browse/HBASE-22052). Did following to verify: 1) Look at commit history for hbase-it. See https://github.com/apache/hbase/commits/branch-2/hbase-it?after=9878b14906320ba6f5ab932cdc51e3e454a82cbd+69 2) Checkout commit for HBASE-22052, build code and run test: FAIL ``` git checkout 939a29b41e0df228891e04b38c109042b8531b59 mvn clean install -DskipTests mvn --no-snapshot-updates -Dtest=IntegrationTestImportTsv -pl hbase-it package ``` 3) Checkout commit just before HBASE-22052 in hbase-it, build code and run test: PASS ``` git checkout 607ac735c4f78595ee8b78a3ddeef8d3d836da7e mvn clean install -DskipTests mvn --no-snapshot-updates -Dtest=IntegrationTestImportTsv -pl hbase-it package ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org