NihalJain commented on code in PR #5625:
URL: https://github.com/apache/hbase/pull/5625#discussion_r1452905201
##########
hbase-it/pom.xml:
##########
@@ -408,6 +408,10 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minikdc</artifactId>
</dependency>
+ <dependency>
Review Comment:
> I think HBASE-22052 is for fixing running IT against a real cluster, where
we do not need to start a mini cluster in process? But anyway, I think if we
can run the IT with a mini cluster, it does not make sense that we can not run
it with a real cluster...
I don't think there should be any change in real env setup with this PR. I
have verified assembly remains same with/without this change. So if we were
able to run IT on real cluster before we should be able to do same with this
change as well, right?
> SO let's just remove the exclusion to see if things go right?
I have added the dependency for only hadoop-2 profile, it avoids exclusion.
Didn't touch the it for hadoop-3 as we don't see any failure there. Let me know
if you want me to remove altogether or if this change itself is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
