[ 
https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418493#comment-13418493
 ] 

Alex Baranau commented on HBASE-6411:
-------------------------------------

bq. For my opinion this removes most abstraction of the actual metrics2 
implementation, which was something I liked about the first approach. It would 
be possible for someone to implement their own metrics1 implementation with the 
earlier approach.

Right. I guess the Q is do we really need this extra abstraction?
At the same time, by adding extra abstraction hadoop-compat with 
hadoop1/2-compat modules in this case turn into smth like metrics-api and 
metrics-impl modules. I.e. not just "shim over hadoop classes". Which may be 
OK, I don't know.
                
> Move Master Metrics to metrics 2
> --------------------------------
>
>                 Key: HBASE-6411
>                 URL: https://issues.apache.org/jira/browse/HBASE-6411
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>            Assignee: Alex Baranau
>         Attachments: HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to