[
https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418578#comment-13418578
]
Alex Baranau commented on HBASE-6411:
-------------------------------------
@Elliott
Abstracting over third-party implementations makes perfect sense to me. With
what you said in ming I guess it leads us to defining a good, more or less
generic metrics-api in compat module, so that one can implement it with any
tools they want (not just with metrics2 of hadoop) and at the same time it is
usable in hbase code. This API might consist of basic interfaces/abstractions
e.g. like in hadoop metrics2 framework: MetricsSystem, MetricsSource,
MetricsSink, MetricInfo (Metric & MetricTag), metric types (counter/gauge),
etc. If we want to define such an API, it will look closer to this patch
though... Otherwise specific classes like: ReplicationMetricsSource doesn't
look like generic API.
Or if we don't need it to be generic, this doesn't sound like *extracting* API
for metrics system to implement, but rather *separating* "hbase-metrics"
module/component, i.e. just putting all classes which implement metrics (incl.
specific for HBase) into separate module (with an api in compat jar). I.e.
*splitting* hbase codebase as opposed to reducing dependency on third party
implementation of a tool (like metrics) _used_ by hbase.
Perhaps, *splitting* hbase codebase (not abstracting from third-party
dependencies) is what really you intend?
> Move Master Metrics to metrics 2
> --------------------------------
>
> Key: HBASE-6411
> URL: https://issues.apache.org/jira/browse/HBASE-6411
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Alex Baranau
> Attachments: HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
