Apache9 commented on code in PR #5688:
URL: https://github.com/apache/hbase/pull/5688#discussion_r1501763135
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/Call.java:
##########
@@ -85,16 +84,15 @@ class Call {
* Builds a simplified {@link #toString()} that includes just the id and
method name.
*/
public String toShortString() {
+ // Call[id=32153218,methodName=Get]
return new ToStringBuilder(this,
ToStringStyle.SHORT_PREFIX_STYLE).append("id", id)
- .append("methodName", md.getName()).toString();
+ .append("methodName", md != null ? md.getName() : "").toString();
Review Comment:
The log has been like this for a long time so just want to keep it align, as
this is not a problem which want to resolve here. Can open another issue for
optimizing this message. For logging in this PR, I outout the response type so
we could know the preamble call type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
