Apache9 commented on code in PR #5688:
URL: https://github.com/apache/hbase/pull/5688#discussion_r1501771630
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##########
@@ -201,23 +209,31 @@ private void failInit(Channel ch, IOException e) {
// fail all pending calls
ch.pipeline().fireUserEventTriggered(BufferCallEvent.fail(e));
shutdown0();
+ rpcClient.failedServers.addToFailedServers(remoteId.getAddress(), e);
Review Comment:
We have this line right after the failInit call when connecting fail, it is
at line 334 in the old code. I moved it here since we will call failInit at
other places, I think for all those cases we should add the server to
failedServers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
