comnetwork commented on code in PR #5817:
URL: https://github.com/apache/hbase/pull/5817#discussion_r1560408293


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdvancedScanResultConsumer.java:
##########
@@ -51,6 +51,18 @@ interface ScanResumer {
      * effect.
      */
     void resume();
+
+    /**
+     * This method is used when {@link ScanController#suspend} had ever been 
called to get a
+     * {@link ScanResumer}, but now you stop the scan and do not need more 
scan results, so you
+     * invoke this method to tell lower layer that scan is stopped by user and 
should release
+     * resources and not initiate new scans any more.
+     * <p>
+     * You are free to call it multiple time but only the first call will take 
effect.
+     */
+    default void terminate() {

Review Comment:
   @Apache9, thank you for review,  I approve your opinion, and resume or 
terminate should be  determined by the internal implementation.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to