Apache9 commented on code in PR #5817:
URL: https://github.com/apache/hbase/pull/5817#discussion_r1562669213
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java:
##########
@@ -143,6 +144,18 @@ private void resumePrefetch() {
resumer = null;
}
+ private void termianteResumerIfPossible() {
Review Comment:
Typo? terminateResumerIfPossible.
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java:
##########
@@ -143,6 +144,18 @@ private void resumePrefetch() {
resumer = null;
}
+ private void termianteResumerIfPossible() {
+ if (resumer == null) {
+ return;
+ }
+ if (resumer instanceof ScanResumerImpl) {
+ ((ScanResumerImpl) resumer).terminate();
Review Comment:
Better add some comments here to explain why we have a cast here, instead of
introduing a method directly in ScanResumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
