jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572161068
########## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ########## @@ -980,9 +991,18 @@ void freeSpace(final String why) { BucketEntryGroup bucketMemory = new BucketEntryGroup(bytesToFreeWithExtra, blockSize, getPartitionSize(memoryFactor)); + long bytesFreed = 0; + // Scan entire map putting bucket entry into appropriate bucket entry // group for (Map.Entry<BlockCacheKey, BucketEntry> bucketEntryWithKey : backingMap.entrySet()) { + + if (coldFiles.containsKey(bucketEntryWithKey.getKey().getHfileName())) { + //coldBlocks.add(bucketEntryWithKey.getKey()); Review Comment: ack! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org