jhungund commented on code in PR #5829:
URL: https://github.com/apache/hbase/pull/5829#discussion_r1572313499
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -999,6 +1019,12 @@ void freeSpace(final String why) {
}
}
+ // Check if the cold file eviction is sufficient to create enough space.
Review Comment:
Ok, given that we do not want to delay the current caching thread any
further once the required space is available. This will also avoid misses on
the remaining cold blocks. Hence, I think, return as soon as the the required
space is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
