Apache9 commented on code in PR #5837:
URL: https://github.com/apache/hbase/pull/5837#discussion_r1599917696
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaRegionLocator.java:
##########
@@ -25,6 +25,7 @@
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.atomic.AtomicReference;
+import org.apache.hadoop.conf.Configuration;
Review Comment:
Not used?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClusterConnectionFactory.java:
##########
@@ -39,7 +39,7 @@ private ClusterConnectionFactory() {
}
private static AsyncClusterConnection
createAsyncClusterConnection(Configuration conf,
- ConnectionRegistry registry, SocketAddress localAddress, User user) throws
IOException {
+ ConnectionRegistry registry, SocketAddress localAddress, User user )
throws IOException {
Review Comment:
Not used?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncMetaRegionLocator.java:
##########
@@ -174,6 +174,7 @@ public void updateCachedLocationOnError(HRegionLocation
loc, Throwable error) {
@Override
public RegionLocations getRegionLocations(TableName tableName,
int replicaId,
boolean reload) throws Exception {
+ final Configuration conf = HBaseConfiguration.create();
Review Comment:
Please remove this useless code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
