Apache9 commented on PR #5837: URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111493641
> > Here you just submit the async zk operation in the timer task, and then in the callback, you check reschedule the timer task and then you have a chance to check timeout, but what if the zk operation does not return within the timeout?... > > @Apache9 this is exactly why i was initially proposing to use CompletableFuture#get with timeout in all callers so that regardless of the ConnectionRegistry implementation, we can still have our timeout at Future object level. I've already mentioned above using CompletableFuture.get is incorrect, the jira title is ConnectionRegistry APIs should have timeout, not the caller should have timeout, and how do you plan to deal with async operations? You should never do future.get in an async operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
