[ 
https://issues.apache.org/jira/browse/HBASE-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426709#comment-13426709
 ] 

Jimmy Xiang commented on HBASE-6460:
------------------------------------

I agree with Jon.  It's better to fix the documentation because we don't 
usually touch orphans in fixing holes. You can always combine different options 
for your use case.

If make sense, we can have other shortcuts too. However, we don't want too many 
shortcuts to avoid some confusion.
                
> hbck "-repairHoles" shortcut doesn't enable "-fixHdfsOrphans"
> -------------------------------------------------------------
>
>                 Key: HBASE-6460
>                 URL: https://issues.apache.org/jira/browse/HBASE-6460
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.94.0, 0.96.0
>            Reporter: Jie Huang
>            Priority: Minor
>         Attachments: hbase-6460.patch
>
>
> According to the hbck's help info, shortcut - "-repairHoles" will enable 
> "-fixHdfsOrphans" as below.
> {noformat}
>  -repairHoles      Shortcut for -fixAssignments -fixMeta -fixHdfsHoles 
> -fixHdfsOrphans
> {noformat}
> However, in the implementation, the function "fsck.setFixHdfsOrphans(false);" 
> is called in "-repairHoles". This is not consistent with the usage 
> information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to