DieterDP-ng commented on code in PR #6370:
URL: https://github.com/apache/hbase/pull/6370#discussion_r1867680938


##########
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackup.java:
##########
@@ -249,4 +377,69 @@ private String takeFullBackup(List<TableName> tables, 
BackupAdminImpl backupAdmi
     checkSucceeded(backupId);
     return backupId;
   }
+
+  private static void doBulkload(TableName tn, String regionName, byte[]... 
fams)

Review Comment:
   There's already some similar HFile creation code in `TestBulkLoadFiles`. I 
suggest trying to reuse that code, or merging this code with the existing code. 
If there's too much difference in functionality, at the very least move these 
methods into that file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to