hgromer commented on code in PR #6370:
URL: https://github.com/apache/hbase/pull/6370#discussion_r1887686853
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java:
##########
@@ -43,8 +44,13 @@ private BackupRestoreFactory() {
* @return backup restore job instance
*/
public static RestoreJob getRestoreJob(Configuration conf) {
+ Class<? extends RestoreJob> defaultCls =
+ conf.getBoolean(RestoreJob.KEEP_ORIGINAL_SPLITS_OPT, false)
Review Comment:
For what it's worth, I think setting the new behavior as default defeats the
logic here
> If we do find an invalid ancestor, what would the expected behavior be?
Bear in mind that we would be reviewing for incompatible ancestors during the
restore process, so any additional processing + exceptions thrown would occur
here.
So I think we need to
1. Keep the existing behavior as default
2. Admit that it's okay to basically break restores for users who are on
this incremental backup system until they're able to take a new full backup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
