DieterDP-ng commented on code in PR #6370:
URL: https://github.com/apache/hbase/pull/6370#discussion_r1901592896
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java:
##########
@@ -43,8 +44,13 @@ private BackupRestoreFactory() {
* @return backup restore job instance
*/
public static RestoreJob getRestoreJob(Configuration conf) {
+ Class<? extends RestoreJob> defaultCls =
+ conf.getBoolean(RestoreJob.KEEP_ORIGINAL_SPLITS_OPT, false)
Review Comment:
@ndimiduk what are your thoughts about my comment?
> If I understand correctly, the downside of this approach versus the old
one is that backup creation requires more work: resources and time. The main
advantage is that restores will be faster, and the future prospect of using
backups as input for jobs as a snapshot-view.
>
> I'm leaning towards keeping the old approach the default, since I assume
restores should be seldomly done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
