stoty commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096968124
##########
hbase-build-configuration/pom.xml:
##########
@@ -82,6 +82,8 @@
<arg>-XDcompilePolicy=simple</arg>
<!-- All -Xep need to be on single line see:
https://github.com/google/error-prone/pull/1115 -->
<arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode
-XepExcludedPaths:.*/target/.* -Xep:FallThrough:OFF -Xep:MutablePublicArray:OFF
-Xep:ClassNewInstance:ERROR -Xep:MissingDefault:ERROR -Xep:BanJNDI:WARN</arg>
+ <!-- Required by error prone >= 2.36.0. See
https://github.com/google/error-prone/commit/e71db1f369a9367f6f2db34c4fbd006b6d6238fd
!-->
Review Comment:
Is this still needed ?
##########
pom.xml:
##########
@@ -1586,6 +1586,17 @@
<scope>test</scope>
</dependency>
</dependencies>
+ <!-- TODO Remove below block, added just for testing -->
Review Comment:
or just set enabled to false by default ?
##########
hbase-build-configuration/pom.xml:
##########
@@ -82,6 +82,8 @@
<arg>-XDcompilePolicy=simple</arg>
<!-- All -Xep need to be on single line see:
https://github.com/google/error-prone/pull/1115 -->
<arg>-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode
-XepExcludedPaths:.*/target/.* -Xep:FallThrough:OFF -Xep:MutablePublicArray:OFF
-Xep:ClassNewInstance:ERROR -Xep:MissingDefault:ERROR -Xep:BanJNDI:WARN</arg>
+ <!-- Required by error prone >= 2.36.0. See
https://github.com/google/error-prone/commit/e71db1f369a9367f6f2db34c4fbd006b6d6238fd
!-->
Review Comment:
I guess it doesn't cause any problems, so we can keep this to keep the
branches closer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
