Apache9 commented on code in PR #6974:
URL: https://github.com/apache/hbase/pull/6974#discussion_r2119176212
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -514,18 +514,25 @@ private void open() throws IOException {
comparator = initialReader.getComparator();
}
+ public void initReader() throws IOException {
+ initReader(false);
+ }
+
/**
* Initialize the reader used for pread.
*/
- public void initReader() throws IOException {
- if (initialReader == null) {
+ public void initReader(boolean reopen) throws IOException {
+ if (initialReader == null || reopen) {
synchronized (this) {
- if (initialReader == null) {
+ if (initialReader == null || reopen) {
+ boolean evictOnClose = cacheConf == null ||
cacheConf.shouldEvictOnClose();
try {
+ if (reopen) {
+ closeStoreFile(evictOnClose);
Review Comment:
For reopen, do we really want to evict block cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
