ndimiduk commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2123183998
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -764,13 +763,24 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
- Throwable t, boolean clearServerCache) {
+ Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+ boolean clearServerCache;
+
+ if (t instanceof RejectedExecutionException) {
Review Comment:
I think that we should add `RejectedExecutionException` to the predicate in
`ClientExceptionsUtil#isMetaClearingException()`. Seems dicy to have a special
case test here. Or am I missing some wider context?
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -764,13 +763,18 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
- Throwable t, boolean clearServerCache) {
+ Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+ boolean clearServerCache = ClientExceptionsUtil.isMetaClearingException(t);
// Do not update cache if exception is from failing to submit action to
thread pool
if (clearServerCache) {
cleanServerCache(server, t);
+
+ if (LOG.isTraceEnabled()) {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
