ndimiduk commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2934354613
> > Looks like the new scope of the work is > > > > 1. Pass the meta clearing exception to `updateCachedLocations` so we can properly capture the exception in the client metric instead of unknown exception > > 2. Pushing `RejectedExecutionException` down into `isMetaClearingException` > > > > I am wondering if it make sense to split these into two different issues given the change in scope? My initial thought is in agreement that `RejectedExecutionException` should not be meta cache clearing, but maybe it would be beneficial to handle that change independently of the client metric fix , there may be implications beyond batch operations for that change. > > It'd make sense for me to have that be it's own thing (one I probably wouldn't own to be completely honest), cc @ndimiduk since I was following his suggestion Oh. I see now that you and droudnitsky are attempting to cut scope. I don't feel great about leaving the `RejectedExecutionException` as it is, but if you'd prefer to isolate that change, then let's proceed with what you have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
