junegunn commented on code in PR #7432:
URL: https://github.com/apache/hbase/pull/7432#discussion_r2486656198
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java:
##########
@@ -352,6 +352,26 @@ public void testScanLimit() throws Exception {
}
}
+ @Test
+ public void testScanLimitOnConfig() throws Exception {
+ testScanLimit(10, new Scan(), 10);
+ }
+
+ @Test
+ public void testScanLimitOnScan() throws Exception {
+ testScanLimit(0, new Scan().setLimit(10), 10);
+ }
+
+ @Test
+ public void testScanLimitOnBothButScanWins() throws Exception {
+ testScanLimit(10, new Scan().setLimit(5), 5);
+ }
+
+ @Test
+ public void testScanLimitOnBothButConfigWins() throws Exception {
+ testScanLimit(5, new Scan().setLimit(10), 5);
+ }
Review Comment:
To verify that the smaller value from the two sources is chosen. Maybe a bit
overkill for such a simple logic? Considering each case takes quite a while to
run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
