junegunn commented on PR #7432: URL: https://github.com/apache/hbase/pull/7432#issuecomment-3486265830
> It will increase the message size for Scan object and does not bring any advantages for Scan, so for me I prefer we do not add it if possible... Fair enough, however small, it's still wasteful. If I'm not mistaken, the serialized size does not increase if we don't set the optional field. So how about overloading `ProtobufUtil.toScan` with a version that skips the field, and using that in normal scans (in `RequestConverter.buildScanRequest`)? It would benefit MR users without introducing unnecessary overhead to normal scans. If that sounds reasonable, I can update the patch; otherwise, I'd say we leave this as a known issue and close it as "wontfix". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
