Copilot commented on code in PR #7610:
URL: https://github.com/apache/hbase/pull/7610#discussion_r2675361073
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java:
##########
@@ -3135,10 +3135,15 @@ GetProcedureResultResponse> call(controller, stub,
.call(),
(response, error) -> {
if (error != null) {
- LOG.warn("failed to get the procedure result procId={}", procId,
- ConnectionUtils.translateException(error));
- retryTimer.newTimeout(t -> getProcedureResult(procId, converter,
future, retries + 1),
- ConnectionUtils.getPauseTime(pauseNs, retries),
TimeUnit.NANOSECONDS);
+ Throwable exc = ConnectionUtils.translateException(error);
+ if (exc instanceof DoNotRetryIOException) {
+ // stop retrying on DNRIOE
Review Comment:
Consider adding a log message when a DoNotRetryIOException is encountered,
similar to how other exceptions are logged at line 3143. This would be
consistent with the logging pattern used elsewhere in the codebase (e.g., line
1064 logs DoNotRetryIOException at INFO level). A log message would help with
debugging and provide visibility into why the procedure result retrieval was
aborted without retries.
```suggestion
// stop retrying on DNRIOE
LOG.info(
"Aborting retries while getting the procedure result procId={}
due to "
+ "DoNotRetryIOException",
procId, exc);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
