Apache9 commented on code in PR #7610:
URL: https://github.com/apache/hbase/pull/7610#discussion_r2675368701
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java:
##########
@@ -3135,10 +3135,15 @@ GetProcedureResultResponse> call(controller, stub,
.call(),
(response, error) -> {
if (error != null) {
- LOG.warn("failed to get the procedure result procId={}", procId,
- ConnectionUtils.translateException(error));
- retryTimer.newTimeout(t -> getProcedureResult(procId, converter,
future, retries + 1),
- ConnectionUtils.getPauseTime(pauseNs, retries),
TimeUnit.NANOSECONDS);
+ Throwable exc = ConnectionUtils.translateException(error);
+ if (exc instanceof DoNotRetryIOException) {
+ // stop retrying on DNRIOE
Review Comment:
In other rpc retrying caller implementation, we will not log the exception
when the exception is used to complete a future. So we just align the behavior
with other retrying caller too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
