DieterDP-ng commented on code in PR #7582:
URL: https://github.com/apache/hbase/pull/7582#discussion_r2676956513
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java:
##########
@@ -228,15 +263,6 @@ private List<String> getLogFilesForNewBackup(Map<String,
Long> olderTimestamps,
} else if (currentLogTS > oldTimeStamp) {
resultLogFiles.add(currentLogFile);
}
-
- // It is possible that a host in .oldlogs is an obsolete region server
Review Comment:
> I don't think so, this would exclude all WAL files between last backup
(previousTimestamps) and the current log roll (newTimestamp). Unless I'm
misunderstanding
A WAL log from between last backup and current log roll would have a
`currentLogTS <= newTimestamp`, no? If `currentLogTS > newTimestamp` it means
it was created after the log roll that just happened, and should be excluded
from the backup (so it should be in `newestLogs`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
