hgromer commented on code in PR #7582: URL: https://github.com/apache/hbase/pull/7582#discussion_r2682104819
########## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java: ########## Review Comment: > One advantage of not basing newTimestamps on the logs, but on the roll timestamps would be that the same logic could be used for full and incremental backups. It's tricky to use `rollTimestamps` b/c we're comparing timestamps across different machines, and so we can run into clock skew issues. If a WAL file for a host is generated roughly at the time we set `rollTimestamps`; and then the host goes offline before it can be rolled. Using WAL timestamps allows us to always compare timestamp values generated by the same machine. We avoid any weird clock skew issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
