Apache9 commented on code in PR #7617:
URL: https://github.com/apache/hbase/pull/7617#discussion_r2736924354
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java:
##########
@@ -229,6 +247,41 @@ private void shipEdits(WALEntryBatch entryBatch) {
}
}
+ private boolean shouldPersistLogPosition() {
+ ReplicationEndpoint endpoint = source.getReplicationEndpoint();
Review Comment:
We only need this configuration in shipper, as persisting the log position
is the duty of shipper, not endpoint. And there is no correctness problem if
you implement the endpoint correctly since when persisting the log position,
you will flush the files in endpoint. The problem is that the performance may
be bad. So when using different replication endpoint implementation, you shoud
tune the configuration in shipper about the persistency interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
